From: Aaron Schulz <aaron@users.mediawiki.org>
Date: Mon, 20 Jul 2009 02:04:54 +0000 (+0000)
Subject: Extra quotes are breaking wfShellExecute() for me...need to look into this more to... 
X-Git-Tag: 1.31.0-rc.0~40816
X-Git-Url: http://git.cyclocoop.org/%27%20.%20%24prefix%20.%20Wiki::transformTitleToURI%28%24matches%5B1%5D%29%20.%20%27?a=commitdiff_plain;h=6988ca0c355e1604b0c490c93acac31d3298f003;p=lhc%2Fweb%2Fwiklou.git

Extra quotes are breaking wfShellExecute() for me...need to look into this more to see what changed (PHP or cmd?)
---

diff --git a/includes/GlobalFunctions.php b/includes/GlobalFunctions.php
index 66cc3ecbf3..30bb00ac01 100644
--- a/includes/GlobalFunctions.php
+++ b/includes/GlobalFunctions.php
@@ -2266,7 +2266,7 @@ function wfShellExec( $cmd, &$retval=null ) {
 	} elseif ( php_uname( 's' ) == 'Windows NT' ) {
 		# This is a hack to work around PHP's flawed invocation of cmd.exe
 		# http://news.php.net/php.internals/21796
-		$cmd = '"' . $cmd . '"';
+		$cmd = '"' . $cmd . '"'; // FIXME: breaking Vista sp2/PHP 5.2.9(2)
 	}
 	wfDebug( "wfShellExec: $cmd\n" );